Pat Thoyts <patthoyts@xxxxxxxxxxxxxxxxxxxxx> wrote: > Victor Engmark <victor.engmark@xxxxxxxxx> writes: > > >Using the git-gui available with the default Ubuntu 10.10 repos, I'm > >not able to unstage files with the default keyboard shortcut. To > >reproduce: > >1. Change a file in the repository > >2. Run `git gui` > >3. Stage the changed file > >4. Select the changed file in the "Staged Changes (Will Commit)" list > >5. Click Ctrl-U > > > >Expected outcome: The selected file should be unstaged. > > > >Actual outcome: Nothing at all changes in the GUI. > > I checked this with the current version (gitgui-0.16.0) and it works ok > for me (on windows) - ie: ctrl-u unstaged a selected file. Pat, it depends on where the focus is when you press ctrl-u. If you click in the diff pane, and then select the file to unstage, and then press ctrl-u, then nothing happens. If you click in the commit message field, then ctrl-u works fine. The same problem exists with ctrl-j for "Revert Changes". In that case it is caused by the vi bindings that were introduced by 60aa065f69. It seems that a binding for <Key-j> is also triggered by ctrl-j (if you have a long diff you can see the diff pane scroll down by one line). I'm not sure how to explain why ctrl-u doesn't work though, as I can't see any binding for <Key-u>, but maybe this gives a clue to someone who knows more about TCL than I do. (It's not Windows-specific, btw: the same problem exists on Mac with Command-U and Command-J.) -- Stefan Haller Berlin, Germany http://www.haller-berlin.de/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html