On Mon, Feb 06, 2012 at 02:13:02AM -0500, Jeff King wrote: > > BTW, writing that helped me notice two bugs in your patch: > > > > 1. You read up to 47 bytes into the buffer without ever checking > > whether size >= 47. > > > > 2. You never check whether the object you read from read_sha1_file is > > actually a tag. > > Hmm, the "filter->lines" code for "git tag -n" makes a similar error. It > should probably print nothing for objects that are not tags. Ugh, this part of builtin/tag.c is riddled with small bugs. I'm preparing a series that will fix them, and hopefully it should make building your points-at patch on top much more pleasant. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html