On Sun, Feb 05, 2012 at 04:39:35PM -0800, Junio C Hamano wrote: > > We could also go as far as saying that map_user would _always_ terminate > > in this way (i.e., the caller gets a munged result, whether we found > > anything or not). Then internally, map_user could be simplified to stop > > worrying about making a temporary copy in mailbuf. And callers could > > simply call map_user without worrying about branching on whether it > > found anything or not. > > I thought about it, but such a change needs to audit all the call sites > that assumes the promise original map_user() used to make before it was > broken. If we return 0 to the caller, the caller does not have to worry > about map_user() munging the buffer it lent to it. > > It might be a worthwhile thing to do. I dunno; I didn't look into it. Ugh, yeah. I was thinking about how it would improve this call site, but I don't want to get into auditing the others. Let's drop it and go with your patch. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html