Hi Junio, > > diff --git a/compat/inet_ntop.c b/compat/inet_ntop.c > > index 60b5a1d..f1bf81c 100644 > > --- a/compat/inet_ntop.c > > +++ b/compat/inet_ntop.c > > @@ -15,11 +15,9 @@ > > * SOFTWARE. > > */ > > > > +#include "../git-compat-util.h" > > #include <errno.h> > > #include <sys/types.h> > > - > > -#include "../git-compat-util.h" > > - > > #include <stdio.h> > > #include <string.h> > > I actually have to wonder if any of these four inclusion of the > system headers are warranted. Wouldn't they be included as part of > git-compat-util.h anyway? Yes, you're correct. Dropping the system includes is correct as opposed to rearranging the order. Updated patch to follow. Thanks -Ben -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html