On Sun, Feb 5, 2012 at 11:12 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: > >> On Sat, Feb 4, 2012 at 5:10 PM, Felipe Contreras >> <felipe.contreras@xxxxxxxxx> wrote: >>> Otherwise, 'git send-email' would be happy to do: >>> >>> % git send-email --to '<foo@xxxxxxx>>' >>> >>> And use '<foo@xxxxxxx>>' in the headers. >> >> Er, actually that's not correct: '<foo@xxxxxxx>>' will remain the >> same, but 'Foo <foo@xxxxxxx>>' will be sanitized. > > I suspect that this "Er" is merely a sympotom of a larger issue in the > approach taken by this patch. The code takes a potentially malformed > input, and applies a rewrite logic without telling the user what it is > doing. That's what the function is doing already: sanitizing the address. > Wouldn't a better approach to detect problem on the input side and reject > a wrong one by erroring out, so that the user has a chance to fix? Perhaps, but the code is not prepared for that. Anyway, feel free to drop it, I am not interested in pursing this. Cheers. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html