On Sun, Feb 05, 2012 at 12:19:53AM +0200, Felipe Contreras wrote: > > Thanks. I guess you think I'm stupid. I have no idea how I can > > correct that assumption and help you to actually work with me to make > > the code better. :/ > > You mean the commit message, you haven't made any comment about the code. > > If you want to know why I had to modify those test assertions, you > really need to look at the code. In essence; all of them use the same > repo, and obviously adding a new commit message changes the output of > the commands. Then say that in the commit message. Looking at this series, I wonder if the tests should simply be squashed into the bugfix patch, which might make what is going on more obvious. Keep in mind that as reviewers now, we read the whole series. But in a year, as "git log" users, we may see the commits in isolation. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html