Re: [PATCH v4 11/13] status: add --column

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Nguyễn Thái Ngọc Duy  <pclouds@xxxxxxxxx> writes:

> @@ -1251,7 +1260,7 @@ int cmd_status(int argc, const char **argv, const char *prefix)
>  	case STATUS_FORMAT_LONG:
>  		s.verbose = verbose;
>  		s.ignore_submodule_arg = ignore_submodule_arg;
> -		wt_status_print(&s);
> +		wt_status_print(&s, colopts);
>  		break;
>  	}

Do you really need to pass colopts around as a separate parameter all the
way through the callchain?

Why isn't it a new member of wt_status that sits next to existing
use_color, verbose, etc. that define _how_ the status is shown?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]