David Howells <dhowells@xxxxxxxxxx> writes: > Valerie Aurora <valerie.aurora@xxxxxxxxx> wrote: > >> And for a complete (meaningful) rewrite such as David has done, he >> changes the commit authorship and adds a Signed-off-by for the >> original author. > > Val[*] hasn't signed off all her patches, and indeed I've merged together some > patches that she has signed off and some she hasn't. I can't simply add > Signed-off-by her without her permission. However, if she's willing for me to > add such lines, then I can do so. > >> Signed-off-by: Some Upstream Author >> Signed-off-by: Maintainer or Merger (rewrote error handling) > > And if the changes are more than can be put in what's left of the line? I > would've thought it would make more sense to do something like: > > Signed-off-by: Valerie Aurora <valerie.aurora@xxxxxxxxx> (Original author) > Signed-off-by: David Howells <dhowells@xxxxxxxxxx> (Further development) > > David That all sounds sensible. I personally think the "recognition" factor Valerie alluded to in one of her earlier message is a real and important issue, but I do not think adding arbitrary number of "author" headers to the commit object would help very much to solve it, for various reasons: * While we made it easy to run "git shortlog -s -n --since=3.months" and congratulate himself with "I now am the third most active person!" for anybody, Git itself does not ship an equally easy way to analyze other kinds of contributions to your project. I am merely a bystander, but if I recall correctly, there were discussions on how to recognize contributions by bug-reporters and testers using the history stored in Git on the kernel list. The types of contribution you would want to recognize however would be different from project to project. For that kind of analysis, you would be better off doing something like what lwn.net does, mining the text from the message part of the log. * Even if we limit the issue to "who wrote X" (replace X with the name of any piece of software), taking "author" field as anything more than an approximation would be asking for a trouble. Not all patches are of equal impact and importance. * You would also have to think about how you would present "git shortlog" output if you updated Git to record more than one "author" field in the commit header. If Valerie wrote 27 patches by herself, 33 patches together with you sitting next to each other, 17 patches with somebody else, how would the entries for her, you and the third person look like? Or would combinations of "Valerie & David", "Valerie & the third person", etc. have separate entries in the output? In short, I would say that you should take the name recorded in the "author" field nothing more than the primary contact for a particular commit to be used in case others have question on it later. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html