Jeff King <peff@xxxxxxxx> writes: > The caller of grep_buffer may have extra information about > whether a buffer is binary or not (e.g., from configuration). > Let's give them a chance to pass along that information and > override our binary auto-detection. Hrm, I would have expected a patch that turns "const char *name" into a structure that has name and drv as its members, so that later we can tell the function more about the nature of the contents. Or a separate pointer to drv in place of your "binary" flag word. I am not saying that your patch is wrong. It was just somewhat unexpected that "binary" is the only additional thing we want to tell the function. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html