Nicolas Pitre <nico@xxxxxxxxxxx> writes: >> +static int find_pack_entry_1(const unsigned char *sha1, >> + struct packed_git *p, struct pack_entry *e) > > This looks all goot but the name. Pretty please, try to find something > that is more descriptive than "1". Suggestions: > "find_pack_entry_lookup", "find_pack_entry_inner", etc. Perhaps "find_pack_entry_in_pack(sha1, e, p)"? That would go well with the caller "find_pack_entry(sha1, e)". -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html