SZEDER Gábor wrote: > On Mon, Jan 30, 2012 at 11:50:04AM -0600, Jonathan Nieder wrote: >> I imagine it would have been enough to say something along the lines of >> "The __gitcomp and __gitcomp_nl functions are unnecessarily verbose. >> __gitcomp_nl sets IFS to " \t\n" unnecessarily > > Yeah, that's unnecessary. I'm not sure why I did that, perhaps just > blindly followed suit of gitcomp_1(), without realizing that I don't > do any word-splitting in __gitcomp_nl() except when invoking compgen. > >> before setting it to "\n" >> by mistake. > > But that is deliberate, that's why it's called __gitcomp_nl(), see > a31e6262 (completion: optimize refs completion, 2011-10-15), third > paragraph. Yep, sorry for the ambiguity. I meant that setting IFS to " \t\n" (before setting it to "\n") was not done for any serious reason. The explanation is definitely clearer with "by mistake" dropped. Thanks, Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html