* Junio C Hamano <gitster@xxxxxxxxx> [120130 21:34]: > "Bernhard R. Link" <brl@xxxxxxxxxxxxxx> writes: > Regarding the first patch in the series, while it may be a valid perl to > introduce a new variable, assign to it and then munge its contents with > s///, all inside a parameter list of a function call, it is doing a bit > too much and makes it hard to see if the variable may or may not later be > used in the same scope (in this case, it is not). I'm fine either way. I had interpreted <201201301442.06707.jnareb@xxxxxxxxx> to be meant this way, but rereading it I am not sure it was meant this way at all. I thought this was to express that those variables are not used outside this scope. Bernhard R. Link -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html