On Mon, Jan 30, 2012 at 8:25 PM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: > Felipe Contreras wrote: > >> The commands might fail, that's why '2> /dev/null' was used before, >> and ':' is used right now. > > Wait, what? > > : is a no-op command. It does not redirect stderr automatically or > do any other magical thing. Why don't you go ahead and try it? bash -c ': echo "err" > /dev/stderr' I don't see anything here. But actually, if I use $(echo "err" > /dev/stderr); _then_ I get something. Smells a lot like a bug to me. In any case, if you expected ':' to print errors, now I understand why you removed 2>/dev/null in eaa4e6e. > [...] >> And IMO harder to read. But you are correct that most of the code uses >> [[]], which I think is a shame. But I guess people want to keep using >> that. > > [[ has simpler syntax wrt quoting and other details. But now that I > check, the code uses [ a lot, too (which, like "test", is a plain > built-in command), so I suppose consistency is the only reason to > prefer one over another. "git log --grep='if \['" tells me the use of > '[' instead of 'test' here is deliberate. Maybe '[' then. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html