On Mon, 30 Jan 2012, Bernhard R. Link wrote: > In a project_list view show breadcrumbs with the currently active > project_filter (and those of parent directories) in the page header. O.K. (though I'd prefer written it less concise and more clear). > Signed-off-by: Bernhard R. Link <brlink@xxxxxxxxxx> > --- > gitweb/gitweb.perl | 14 ++++++++++++++ > 1 files changed, 14 insertions(+), 0 deletions(-) > > diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl > index e022e11..dfc79df 100755 > --- a/gitweb/gitweb.perl > +++ b/gitweb/gitweb.perl > @@ -3836,6 +3836,18 @@ sub print_header_links { > } > } > > +sub print_nav_breadcrumbs_path { > + my $dirprefix = undef; > + while (my $part = shift) { Hmmm... using agument list directly, without copying it? Well, all right. > + $dirprefix .= "/" if defined $dirprefix; > + $dirprefix .= $part; > + print $cgi->a({-href => href(project => undef, > + project_filter => $dirprefix, > + action=>"project_list")}, Minor nitpick: Let's use same whitespace rules for all key-value pairs + action => "project_list")}, > + esc_html($part)) . " / "; > + } > +} > + > sub print_nav_breadcrumbs { > my %opts = @_; > > @@ -3854,6 +3866,8 @@ sub print_nav_breadcrumbs { > print " / $opts{-action_extra}"; > } > print "\n"; > + } elsif (defined $project_filter) { > + print_nav_breadcrumbs_path(split '/', $project_filter); > } > } Nice! -- Jakub Narebski Poland -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html