On Mon, Jan 30, 2012 at 4:50 AM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote:
> Felipe Contreras wrote:
>
>> No need for thus rather complicated piece of code :)
> [...]
>> contrib/completion/git-completion.bash | 30 ------------------------------
>> 1 files changed, 0 insertions(+), 30 deletions(-)
> [...]
>> --- a/contrib/completion/git-completion.bash
>> +++ b/contrib/completion/git-completion.bash
>> @@ -2730,33 +2730,3 @@ if [ Cygwin = "$(uname -o 2>/dev/null)" ]; then
> [...]
>> -if [[ -n ${ZSH_VERSION-} ]]; then
>> - __git_shopt () {
> [...]
>> -else
>> - __git_shopt () {
>> - shopt "$@"
>> - }
>> -fi
>
> What codebase does this apply to? My copy of git-completion.bash
> contains a number of calls to __git_shopt, which will fail after this
> change.
The latest and greatest of course:
http://git.kernel.org/?p=git/git.git;a=blob;f=contrib/completion/git-completion.bash
It's only used in __git_remotes.
> By the way, is there any reason you did not cc this series to Gábor or
> others who also know the completion code well? The patches are not
> marked with RFC/ so I assume they are intended for direct application,
> which seems somewhat odd to me.
No reason. I hope they read the mailing list, otherwise I'll resend
and CC them. A get_maintainers script, or something like that would
make things easier.
Cheers.
--
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html