Felipe Contreras wrote: > * ${1-} is the same as $1 | $ git log -S'${1-}' contrib/completion/git-completion.bash | [...] | commit 25a31f81 | Author: Ted Pavlic <ted@xxxxxxxxxxxxx> | Date: Thu Jan 15 11:02:21 2009 -0500 | | bash-completion: Support running when set -u is enabled | | Under "set -u" semantics, it is an error to access undefined variables. | Some user environments may enable this setting in the interactive shell. | | In any context where the completion functions access an undefined | variable, accessing a default empty string (aka "${1-}" instead of "$1") | is a reasonable way to code the function, as it silences the undefined | variable error while still supplying an empty string. | | In this patch, functions that should always take an argument still use | $1. Functions that have optional arguments use ${1-}. | | Signed-off-by: Ted Pavlic <ted@xxxxxxxxxxxxx> | Acked-by: Shawn O. Pearce <spearce@xxxxxxxxxxx> | Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx> Hope that helps, Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html