Junio C Hamano wrote in "Re: [PATCH] gitweb: Better symbolic link support in "tree" view": > If you wanted to do this, a better way would be to have a new > view that takes a commit/tree object and a path from the top of > the repository, and shows either "no such path in that tree" or > "here is the view for that object, by the way it was a blob." > page. Then your list drawing would still need to open each > symlink blob to show " -> link_target", and need to check if it > goes outside the repository (I would assume you are handling > relative links as well), but you do not need to do expensive > ls-tree step one per symlink on the page. The href attr of the > A element " -> link_target" would point at that "universal > object view" with the link_target pathname (that is, the blob > contents) and the commit/tree object name (h or hb I do not know > which) and you will spend cycles to run ls-tree only when the > user actually asks to follow that link. > > In other words, I think trying to be lazy is extremely important > while drawing a big list. I not necessarily agree; I think that symbolic links are sufficnetly rare that a bit more time spent to make the view better for end user (link only if target exists) is worth it. But... Here follows the implementation of this idea: first to read link target and show it in "tree" view _without_ hyperlink, then introduction of generic "object" view which does the verification and redirect to correct view accorting to the type of object, and last show link target hyperlinked in "tree" view using "object" view/action link. While at it implement the same "lazy" solution in commitsha1 commitag in format_log_line_html subroutine. Table of contents: [PATCH 1/3] gitweb: Show target of symbolic link in "tree" view [PATCH 2/3] gitweb: Add generic git_object subroutine to display object of any type [PATCH 3/3] gitweb: Hyperlink target of symbolic link in "tree" view (if possible) [PATCH/RFC 4/3] gitweb: SHA-1 in commit log message links to "object" view Diffstat: gitweb/gitweb.perl | 152 ++++++++++++++++++++++++++++++++++++++++++++++----- 1 files changed, 137 insertions(+), 15 deletions(-) -- Jakub Narebski ShadeHawk on #git Torun, Poland - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html