Jeff King <peff@xxxxxxxx> writes: > And no, I didn't do any cycle detection. We could either do: > > 1. Record some canonical name for each source we look at (probably > realpath() for files, and the sha1 for refs), and don't descend > into already-seen sources. > > 2. Simply provide a maximum depth, and don't include beyond it. > > The latter is much simpler to implement, but I think the former is a > little nicer for the user. Another thing I wondered after reading this patch was that it will be a rather common "mistake" to include the same file twice, one in ~/.gitconfig and then another in project specific .git/config, or more likely, people start using useful ones in ~their/.gitconfig, and then the site administrator by popular demand adding the same include in /etc/gitconfig to retroactively cause the same file included twice for them. Your first alternative solution should solve this case nicely as well, I would think. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html