Re: [PATCH 1/5] t0061: Fix incorrect indentation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 25 Jan 2012 08:00:57 +0100, Junio C Hamano <gitster@xxxxxxxxx> wrote:

"Frans Klaver" <fransklaver@xxxxxxxxx> writes:

On Tue, 24 Jan 2012 23:40:00 +0100, Jonathan Nieder
<jrnieder@xxxxxxxxx> wrote:

Frans Klaver wrote:

+++ b/t/t0061-run-command.sh
@@ -8,8 +8,8 @@ test_description='Test run command'
. ./test-lib.sh

cat >hello-script <<-EOF
-	#!$SHELL_PATH
-	cat hello-script
+#!$SHELL_PATH
+cat hello-script
 EOF

Looks like a no-op --- the script already started with #! and no
leading tab for me.  Does it behave differently on your machine?

Hurr? I'm fairly sure the script ended up being indented for me. I'll
recheck.

It could be that your shell is broken and does not understand the
distinction between the "<<-EOF" vs "<<EOF". What system are you on?

Gentoo Linux, using bash. Would be hard to believe bash on plain old linux mucks this up, wouldn't it?


If
the problem is real and widespread, we might want to mention it in INSTALL
or Makefile, just like we label Solaris /bin/sh as unusable and advise
people to use /usr/xpg[46]/bin variant.

I'll check and notify.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]