Re: [PATCH] t/Makefile: Use $(sort ...) explicitly where needed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Kirill Smelkov <kirr@xxxxxxxxxxxxxx> writes:

> Starting from GNU Make 3.82 $(wildcard ...) no longer sorts the result
> (from NEWS):
>
>     * WARNING: Backward-incompatibility!
>       Wildcards were not documented as returning sorted values, but the results
>       have been sorted up until this release..  If your makefiles require sorted
>       results from wildcard expansions, use the $(sort ...)  function to request
>       it explicitly.
>
>     http://repo.or.cz/w/make.git/commitdiff/2a59dc32aaf0681dec569f32a9d7ab88a379d34f
>
> so we have to sort tests list or else they are executed in seemingly
> random order even for -j1.

I do not necessarily buy your "so we HAVE TO, OR ELSE".

Even though I can understand "We can sort the list of tests _if_ we do not
want them executed in seemingly random order when running 'make -j1'", I
tend to think that *if* is a big one.  Aren't these tests designed not to
depend on each other anyway?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]