On Thu, Jan 19, 2012 at 12:43 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>
> But I personally find your loop is even more disgusting
Yeah, I can't really argue with that.
The thing I was playing with was to move the entire loop content into
a helper function (which would return the new pp), and then the
"first-parent only" case just wouldn't do a loop at all.
But I couldn't be bothered. Your patch certainly does have the
advantage of being minimally intrusive.
Linus
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html