luke@xxxxxxxxxxx wrote on Mon, 16 Jan 2012 23:14 +0000:
> Don't use shell expansion when detecting branches, as it will
> fail if the branch name contains a shell metachar. Similarly
> for labels.
>
> Add additional test for branches with shell metachars.
Nice. There will be a fixup on a command in Vitor's series,
depending on which goes first. He'll have a couple of
un-listified read_pipe{,_lines} that we should treat similarly.
> @@ -1758,7 +1758,7 @@ class P4Sync(Command, P4UserMap):
> def getLabels(self):
> self.labels = {}
>
> - l = p4CmdList("labels %s..." % ' '.join (self.depotPaths))
> + l = p4CmdList(["labels", "%s..." % ' '.join (self.depotPaths)])
> if len(l) > 0 and not self.silent:
> print "Finding files belonging to labels in %s" % `self.depotPaths`
I suspect the command "p4" "labels" "//depot/foo/... //depot/bar/..."
might confuse p4, but haven't tested. Maybe tuck each one in its
own argument?
["labels"] + ["%s..." % p for p in self.depotPaths]
What happened to your failing test? It's fun to keep the broken
ones around to inspire others to fix them.
-- Pete
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html