Otherwise the i18n is used in the scripts even with NO_GETTEXT set. It is very unexpected. --- I usually disable i18n on my working systems as they are generally very out-of-date and not supported by any sane developer. In particular the gettext provided with this (very old) Cygwin distribution is fubar and never produces any output. Makefile | 1 + git-sh-i18n.sh | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index a782409..d82ea6a 100644 --- a/Makefile +++ b/Makefile @@ -1887,6 +1887,7 @@ sed -e '1s|#!.*/sh|#!$(SHELL_PATH_SQ)|' \ -e 's/@@GIT_VERSION@@/$(GIT_VERSION)/g' \ -e 's|@@LOCALEDIR@@|$(localedir_SQ)|g' \ -e 's/@@NO_CURL@@/$(NO_CURL)/g' \ + -e 's/@@NO_GETTEXT@@/$(NO_GETTEXT)/g' \ -e $(BROKEN_PATH_FIX) \ $@.sh >$@+ endef diff --git a/git-sh-i18n.sh b/git-sh-i18n.sh index b4575fb..7f7e32b 100644 --- a/git-sh-i18n.sh +++ b/git-sh-i18n.sh @@ -18,7 +18,7 @@ export TEXTDOMAINDIR if test -z "$GIT_GETTEXT_POISON" then - if test -z "$GIT_INTERNAL_GETTEXT_TEST_FALLBACKS" && type gettext.sh >/dev/null 2>&1 + if test -z "@@NO_GETTEXT@@" && test -z "$GIT_INTERNAL_GETTEXT_TEST_FALLBACKS" && type gettext.sh >/dev/null 2>&1 then # This is GNU libintl's gettext.sh, we don't need to do anything # else than setting up the environment and loading gettext.sh @@ -29,7 +29,7 @@ then # can't. . gettext.sh - elif test -z "$GIT_INTERNAL_GETTEXT_TEST_FALLBACKS" && test "$(gettext -h 2>&1)" = "-h" + elif test -z "@@NO_GETTEXT@@" && test -z "$GIT_INTERNAL_GETTEXT_TEST_FALLBACKS" && test "$(gettext -h 2>&1)" = "-h" then # We don't have gettext.sh, but there's a gettext binary in our # path. This is probably Solaris or something like it which has a -- 1.7.8.2.388.ge40c2
From 36e73fe14cbecd04512a6e8a21b9eb14d278d1dc Mon Sep 17 00:00:00 2001 From: Alex Riesen <raa.lkml@xxxxxxxxx> Date: Tue, 17 Jan 2012 14:25:24 +0100 Subject: [PATCH] i18n: disable i18n for shell scripts if NO_GETTEXT defined Otherwise the i18n is used in the scripts even with NO_GETTEXT set. It is very unexpected. I generally disable i18n on my working systems as they are generally very out-of-date and not supported by any sane developer. In particular the gettext provided with this (very old) Cygwin distribution is fubar and never produces any output. --- Makefile | 1 + git-sh-i18n.sh | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index a782409..d82ea6a 100644 --- a/Makefile +++ b/Makefile @@ -1887,6 +1887,7 @@ sed -e '1s|#!.*/sh|#!$(SHELL_PATH_SQ)|' \ -e 's/@@GIT_VERSION@@/$(GIT_VERSION)/g' \ -e 's|@@LOCALEDIR@@|$(localedir_SQ)|g' \ -e 's/@@NO_CURL@@/$(NO_CURL)/g' \ + -e 's/@@NO_GETTEXT@@/$(NO_GETTEXT)/g' \ -e $(BROKEN_PATH_FIX) \ $@.sh >$@+ endef diff --git a/git-sh-i18n.sh b/git-sh-i18n.sh index b4575fb..7f7e32b 100644 --- a/git-sh-i18n.sh +++ b/git-sh-i18n.sh @@ -18,7 +18,7 @@ export TEXTDOMAINDIR if test -z "$GIT_GETTEXT_POISON" then - if test -z "$GIT_INTERNAL_GETTEXT_TEST_FALLBACKS" && type gettext.sh >/dev/null 2>&1 + if test -z "@@NO_GETTEXT@@" && test -z "$GIT_INTERNAL_GETTEXT_TEST_FALLBACKS" && type gettext.sh >/dev/null 2>&1 then # This is GNU libintl's gettext.sh, we don't need to do anything # else than setting up the environment and loading gettext.sh @@ -29,7 +29,7 @@ then # can't. . gettext.sh - elif test -z "$GIT_INTERNAL_GETTEXT_TEST_FALLBACKS" && test "$(gettext -h 2>&1)" = "-h" + elif test -z "@@NO_GETTEXT@@" && test -z "$GIT_INTERNAL_GETTEXT_TEST_FALLBACKS" && test "$(gettext -h 2>&1)" = "-h" then # We don't have gettext.sh, but there's a gettext binary in our # path. This is probably Solaris or something like it which has a -- 1.7.8.2.388.ge40c2