Jeff King <peff@xxxxxxxx> writes: > Nice. Many times I have added such a "bash" or "gdb" invocation then > forgotten "-v", only to scratch my head at why the test seemed to be > hanging. > > Two minor nits on the patch itself: > ... > 1. It may be worth putting a warning in the comment that this is never > to be used in a real test, but only temporarily inserted. > > 2. I do this not just with bash, but with "gdb". I wonder if it is worth > making this "test_foo bash", for some value of "foo" (the ones that > occur to me are "debug" and "run", but of course they are taken). > > Actually, I wonder if the existing test_debug could handle this > already (though you do have to remember to add "--debug" to your > command line, then). I wondered the same thing from a different angle. My first reaction was "Why is this called 'bash' not 'sh'?" which naturally led to the same direction as yours "why not an arbitrary command 'test_debug xxx'?" test_pause perhaps? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html