Jens.Lehmann@xxxxxx wrote on Mon, 16 Jan 2012 21:48 +0100: > Am 16.01.2012 21:11, schrieb Jeff King: > > On Mon, Jan 16, 2012 at 09:01:21PM +0100, Jens Lehmann wrote: > > > >> So I vote for your patch as it takes my initial idea even further. I > >> really like that HOME, TERM and SHELL are honored in your version > >> leaving the user with a fully functional shell of his choice. > > > > I'm actually mildly negative on this feature, as it interferes with the > > tests themselves. Probably TERM and SHELL don't matter. But $HOME means > > git will read your personal .gitconfig, not any config (or lack thereof) > > in the trash directory. > > Good point, I haven't thought of that ... so yes, at least $HOME should > go. I, too, have stumbled over differences that are due to picking up something in $HOME. It takes a minute to realize what's going on. TERM can interfere with at least one test: c2116a1 (test-lib: fix TERM to dumb for test repeatability, 2008-03-06). SHELL can cause issues when it is more feature-ful than SHELL_PATH. On the other hand, it's frustrating to work in an environment without my shell aliases, git aliases, readline customizations, personal path, and assorted environment variables. I'm comfortable with the (rare?) possibility of confusion. But perhaps it is unwise to support a feature with so many caveats, even if it is only for debugging. -- Pete -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html