On Thu, Jan 12, 2012 at 11:19:37PM -0800, Junio C Hamano wrote: > I wanted to make sure I understood the root cause of the issue and the > approach the patch takes to address it, instead of committing something > that smelled correct. And the only way I know to do so is to write it > down. I use something of the same technique myself... > Especiallly, before coming up with the description, I was wondering if > this kind of symptom appears in non-thin cases, but after writing down the > justification for this patch, it became clear that we wouldn't have to > worry too much about that case. In a non-thin pack, we need to record one > object at least in a delta family in inflated base form, so we may as well > send that one near the tip that is already in that form for that, letting > the existing "avoid futile delta" heuristics to kick in. Other objects in > the same delta family will delta against it. Exactly. You asked earlier why my one-liner patch was not in the first message. It's because it was only through writing the first message that I came to the same realization. :) -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html