Hi, On Thursday 12 January 2012 10:26:41 Jonathan Nieder wrote: > These lines should be left out [*]. Sorry, I wasn't sure whether to remove them or not. I followed the description in git-format-patch(1) on how to send patches with kmail. I'll remove them in the future. Thanks for the advice. > I assume this was prompted by warning messages like this one: > > In git-blame-cleanup: > git-blame.el:306:6:Warning: `mapcar' called for effect; use `mapc' or > `dolist' instead > > Looks reasonable to my very much untrained eyes, and it's consistent > with the hints Kevin gave at [1]. Yes. I think the warnings are correct and should be addressed. E.g. Using mapcar compared to mapc is slower due to the required accumulation of the results and the additional garbage collection costs. It's not very dramatic but there is no reason not to fix it imho. Regards, Rüdiger -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html