On Wed, Jan 11, 2012 at 04:00:38PM -0800, Junio C Hamano wrote: > Yeah, that is definitely a leak. Here it is with a commit message. "valgrind git cherry-pick" reports no leaks in the attr code after this (but unfortunately still lots of leaks from unpack-trees). -Peff -- >8 -- Subject: [PATCH] attr: fix leak in free_attr_elem This function frees the individual "struct match_attr"s we have allocated, but forgot to free the array holding their pointers, leading to a very minor memory leak. Signed-off-by: Jeff King <peff@xxxxxxxx> --- attr.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/attr.c b/attr.c index 96eda0e..303751f 100644 --- a/attr.c +++ b/attr.c @@ -301,6 +301,7 @@ static void free_attr_elem(struct attr_stack *e) } free(a); } + free(e->attrs); free(e); } -- 1.7.9.rc0.33.gd3c17 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html