Ramkumar Ramachandra wrote:
> For the first kind of error, it is insufficient to
> check if the buffer beings with a "pick" or "revert", otherwise the
> following insn sheet would be interpreted as having a malformed object
> name:
> pickle a1fe57~2
>
> In reality, the issue is that "pickle" is an unrecognized instruction.
> So, check that the buffer starts with ("pick " or "pick\t") and
> ("revert " or "revert\t").
Sorry, the above description just leaves me more confused than before.
What _actual impact_ does this patch have? And why do we want it?
And what could be the bad side effects? Everything else is just
irrelevant.
Before reading the above description, I thought this was just a code
cleanup. So either the description or my reading is completely
confused.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html