Jakub Narebski <jnareb@xxxxxxxxx> writes: > When gitweb URL does not provide action explicitly, e.g. > > http://git.example.org/repo.git/branch > > dispatch() tries to guess action (view to be used) based on remaining > parameters. Among others it is based on the type of requested object, > which gave problems when asking for non-existent branch or file (for > example misspelt name). Ok. "gave problems" is a bit unclear to see why explicitly calling die_error() is an improvement, though. What is the nature of the "problems"? Giving a server error 500 because later codepaths tried to call an undefined subroutine? > Now undefined $action from dispatch() should not result in problems. Again, unspecified "problems" here. I'd like this sentence to end with "should not result in X but gives an explicit '404 not found' error". Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html