On Fri, Jan 06, 2012 at 02:49:05PM -0800, Junio C Hamano wrote: > > but it seems that the best course of action would be to drop it > and queue your re-roll afresh, aiming for the next cycle. Here's the re-rolled series, also available as cb/git-daemon-tests based on current master at https://github.com/drizzd/git . [PATCH 1/5] run-command: optionally kill children on exit [PATCH 2/5] run-command: kill children on exit by default [PATCH 3/5] git-daemon: add tests [PATCH 4/5] git-daemon: produce output when ready [PATCH 5/5] git-daemon tests: wait until daemon is ready On Fri, Jan 06, 2012 at 05:32:15PM -0500, Jeff King wrote: > On Fri, Jan 06, 2012 at 08:48:00PM +0100, Clemens Buchacher wrote: > > > I have rebased Junio's cb/git-daemon-tests onto your > > jk/child-cleanup and replaced the call to pkill with a regular kill > > command. > > Looks pretty good from my cursory examination. I think you should fill > out the rationale for "kill dashed externals on exit" a bit. My > reasoning is that whether a git command is an internal or external > process is purely an implementation detail, and killing the git wrapper > should behave identically in both cases. The previous version of this patch only changed the behavior for users of run_command_v_opt, but not for those who filled out the child_process structure by themselves. I could have manually enabled all of those, but that felt unnatural. Instead, I have now reversed the meaning of clean_on_exit to stay_alive_on_exit in [PATCH 2/5] run-command: kill children on exit by default. Cleanup is on by default and callers of run_command must disable it if children should stay alive. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html