mhagger@xxxxxxxxxxxx writes: > I suppose, though I didn't verify, that the old function signature was > a vestige of its earlier having been used as a callback function. But > it doesn't really matter; the point is that the extra arguments are > currently not needed. Yeah, since 8a65ff7 (Generalize the "show each ref" code in receice-pack, 2005-07-02) the function has always been fed to for_each_ref(), but when 6b01ecf (ref namespaces: Support remote repositories via upload-pack and receive-pack, 2011-07-08) introduced show_ref_cb() as the callback that uses show_ref() as a helper, it forgot to do the clean-up in this patch. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html