Jeff King <peff@xxxxxxxx> writes: > The worst potential problem I could come up with is if you somehow had > an object whose "parsed" flag was set, but somehow didn't have its other > fields set (like type). > ... > So I think it is safe short of somebody doing some horrible manual > munging of a "struct object". Yeah, I was worried about codepaths like commit-pretty-printing might be mucking with the contents of commit->buffer, perhaps reencoding the text and then calling parse_object() to get the unmodified original back, or something silly like that. But the lookup_object() call at the beginning of the parse_object() already prevents us from doing such a thing, so we should be OK, I would think. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html