2012/1/4 Junio C Hamano <gitster@xxxxxxxxx>: > Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes: >> We should also fetch tags that reference to downloaded objects. > > I do not think this has much merit. I disagree. Its useful because cloning a branch immediately after it has been tagged for a release should have `git describe` provide back the name of the release from the tag (assuming of course no new commits were made since the tag). > The usual tag-following rules AFAIK > assumes that if you have the commit C then you ought to have all the > ancestors of C, which does not apply at all for the shallow hack to begin > with, and if you make the rule apply for the shallow hack, you would end > up slurping the objects that are needed only for ancient versions, which > would defeat the objective of this patch, no? We aren't talking about fetching the ancient history tags. We are talking about fetching a tag that *directly* points at one of the commits we did download the complete tree of. > It also is my understanding that the shallow hack is almost always used > with a depth of one, not a range, like "git archive | tar xf -", so if > anything, I would say a single-branch cloning has much higher priority > than following tags. I think I agree with you on priority of work effort. But I lack time to make good on that by writing the code myself. :-) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html