Am 28.12.2011 03:34 schrieb Junio C Hamano: >> + close ($fh); > > It seems that we aquired a SP after "close" compared to the > original. What's the prevailing coding style in our Perl code? > > This close() of pipe to the subprocess is where a lot of error checking > happens, no? Can this return an error? > > I can see the original ignored an error condition, but do we care, or not > care? close() can return a number in case of an error, but we already got our response/line, so why care? -- Best regards, Sven Strickroth ClamAV, a GPL anti-virus toolkit http://www.clamav.net PGP key id F5A9D4C4 @ any key-server -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html