Sven Strickroth <sven.strickroth@xxxxxxxxxxxxxxx> writes: > git-svn reads usernames (and other stuff) from an interactive terminal. > This behavior cause GUIs to hang waiting for git-svn to complete (http://code.google.com/p/tortoisegit/issues/detail?id=967). (style) Wrap the line perhaps after "to complete". Does the above mean "GUIs hang, until the user goes back to the terminal and authenticates"? Where is the "interactive terminal" connected when running the GUI? With that bit information, I think the above is a decent problem description (i.e. "what problem is this change trying to solve? is it worth solving?"). The second paragraph (missing) should then discuss what approach is taken by the proposed patch to solve that problem. Something like Instead of using hand-rolled prompt-response code that only works with the interactive terminal, use the git_prompt() method introduced in the earlier commit. would suffice (I didn't check what method name you used, though). > Also see commit 56a853b62c0ae7ebaad0a7a0a704f5ef561eb795. I checked that commit, and what you wanted to say is unclear. Are you saying this patch attempts to fix the breakage by that commit? That commit tried to go in a right direction but did not go far enough and you are trying to enhance it? Somerthing else? Which means that you shouldn't have said "Also see..." at all and instead directly said what you wanted to say here. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html