Jeff King <peff@xxxxxxxx> writes: > Here's how I would have done it. Not involving %w at all, but applying > equally to all placeholders. Hmm, just curious why you rejected the %w() approach, as enhancing %w sounded to me like a better approach at the design level, but that was a knee-jerk reaction without inspecting the codepaths involved myself hence not knowing the potential amount of work required. > - userformat_want_item should also respect the same magic (it already > duplicates some of the "-/+/ " magic. It might be nice to factor > that part out). I recall this was a bit of a bear when I looked at the area last time. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html