Brandon Casey <casey@xxxxxxxxxxxxxxx> writes:
> * new test cases can be dropped into the t4018 directory
> * filenames end with the pattern name e.g. .cpp .objc .matlab etc.
> * filenames should be descriptive since it will be used in the test
> suite output
> * broken test cases should be given a filename prefixed with "broken_"
Cute. I like the general idea.
> * test cases must provide a function named "RIGHT_function_hunk_header"
> - this is the function name that should appear on the hunk header line
> - the body of this function should have an assignment like
>
> answer = 0
>
> The test suite will modify the above line to produce a difference
> from the original. Additionally, this should be far enough within
> the body of the function so that the function name is not part of
> the lines of context.
Although I do not think of any language with a syntax rule where that the
overlong RIGHT_func... token is an illegal symbol offhand, this feels a
bit _too_ specific to the C language. I would prefer something like this
instead:
* a test case must have one (and only one) line that contains "RIGHT"
(all uppercase) and that line should become the hunk header for the
test to succeed.
* after the line that contains "RIGHT" token, there should be one (and
only one) line that contains "ChangeMe". The test modifies this
token to "IWasChanged", compares the original with the modified
result, and expects the "RIGHT" token above appears on the hunk
header.
Also I would prefer not to require "enough filler", as we might want to
enhance the logic to consider using a line in the pre-context as the hunk
header in some cases, e.g.
@@ ... @@ int RIGHT_function_hunk_header(void)
int RIGHT_function_hunk_header(void)
{
- int ChangeME;
+ int IWasChanged;
printf("Hello, world\n");
return 0;
}
@@ ...
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html