Jeff King wrote: > But when you think about it, if our funcname pattern is bad, shouldn't > preventing (2) be the right thing? That is, if our funcname pattern is > really worse than the default language-agnostic match, wouldn't we be > doing everybody a service to simply remove the builtin > diff.cpp.xfuncname pattern? I don't see why. Anyone who has set "diff=cpp" either likes suffering (maybe they are hoping to improve the pattern) or is working with a codebase for which the current pattern works better than the default behavior (maybe their codebase has a lot of goto labels aligned at column zero). So removing the funcname pattern can only hurt them. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html