Here's v2 of this series. It grew a bit since the last round, as I figured fixing the error-paths in compat/setenv.c made sense to do while I was at it, considering how Windows (which is one of the few likely platforms to be able to actually trigger this issue) use it. Erik Faye-Lund (4): compat/setenv.c: update errno when erroring out compat/setenv.c: error if name contains '=' wrapper: supply xsetenv and xputenv use wrapper for unchecked setenv/putenv calls builtin/clone.c | 2 +- builtin/commit.c | 6 +++--- builtin/help.c | 4 ++-- builtin/init-db.c | 2 +- builtin/merge.c | 4 ++-- builtin/notes.c | 2 +- builtin/remote-ext.c | 4 ++-- builtin/revert.c | 2 +- compat/setenv.c | 10 ++++++++-- config.c | 2 +- exec_cmd.c | 4 ++-- git-compat-util.h | 2 ++ git.c | 18 +++++++++--------- pager.c | 2 +- run-command.c | 2 +- setup.c | 6 +++--- wrapper.c | 14 ++++++++++++++ 17 files changed, 54 insertions(+), 32 deletions(-) -- 1.7.7.1.msysgit.0.272.g9e47e -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html