On Tue, Dec 13, 2011 at 10:28:07PM +0100, Sebastian Schuberth wrote: > On Tue, Dec 13, 2011 at 21:17, Jeff King <peff@xxxxxxxx> wrote: > > > We don't currently test this case at all, and instead just > > test the DAV mechanism over an unauthenticated push. That > > isn't very realistic, as most people will want to > > authenticate pushes. > > Thanks for adding this, Peff! You're welcome. Thank you for forwarding the bug report. I would never have seen it on the msysgit list, and for some reason it seems that msysgit people are more likely to use DAV. Having looked a lot at the http code the past month or two, I knew it was pretty flaky and I was nervous when we added Stefan's patch (and no, I don't blame Stefan; his patch was completely reasonable, but just happened to trigger a problem in a seldom-looked-at corner of the code). But I hadn't looked at http-push at all until yesterday, and it didn't even occur to me that there was another whole area of code relying in a very obscure way on the http.c auth code. I'll take a look at some of the refactoring I've done in http.c (both for the credentials topic as well as the bundle topic) and see if we can't integrate http-push.c a little more smoothly. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html