On Mon, Dec 12, 2011 at 11:53:28AM -0800, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > The code for a verbose flag has been here since "git mv" was > > converted to C many years ago, but actually getting the "-v" > > flag from the command line was accidentally lost in the > > transition. > > > > Signed-off-by: Jeff King <peff@xxxxxxxx> > > --- > > This has been broken since 2006, so I guess nobody really cares. But > > it's simple to fix. > > Heh. It means nobody exercised the codepaths that are inside "if (verbose)", > so it may uncover old bugs, no? I thought that at first, too, but actually there is only one code path currently enabled by "verbose", and it is to print "Renaming ...". You can also exercise that code path with "--dry-run" (and the whole path consists of only a single printf, so hopefully we didn't manage to squeeze any bugs in there). Once upon a time, the verbose flag was passed on to add_file_to_index, but that was dropped when the code switched to using rename_index_entry_at in 81dc230 (git-mv: Keep moved index entries inact, 2008-07-21). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html