Jonathan Nieder <jrnieder@xxxxxxxxx> writes:
> Sorry, I was thinking narrowly about the "git log" tests in
> t7006-pager.sh. I was saying that there, the fact that
> lib-terminal.sh creates an environment in which stdin is not
> guaranteed to be a terminal is a feature, not a bug, since it improves
> the test coverage (and I tend to find the "stdin not a tty" case more
> interesting).
I agree with Thomas's objective of giving ttys to all the streams of
process being tested by default to emulate the usage better, but I also
think being able to test some of the streams redirected to non-tty a good
feature to have in test-terminal driver. And I do not think these two have
to be either-or proposition.
I do not think "Run 'git log' as if the user is on an interactive
terminal, but has plugged /dev/null to its standard input" can be spelled
like this:
test-terminal git log </dev/null
but test-terminal could learn an equivalent feature perhaps from the
command line, no? Perhaps like
test-terminal --stdin=/dev/null git log
test-terminal --stdout=actual --stderr=error git shortlog
or somesuch?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html