Jeff King <peff@xxxxxxxx> writes:
> Instead, let's show an error message like:
>
> $ git mv one two three
> fatal: destination 'three' is not a directory
Makes perfect sense.
> We could leave the usage message in place, too, but it
> doesn't actually help here. It contains no hints that there
> are two forms, nor that multi-file form requires that the
> endpoint be a directory. So it just becomes useless noise
> that distracts from the real error.
>
> Signed-off-by: Jeff King <peff@xxxxxxxx>
> ---
> builtin/mv.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/builtin/mv.c b/builtin/mv.c
> index 11abaf5..ae6c30c 100644
> --- a/builtin/mv.c
> +++ b/builtin/mv.c
> @@ -94,7 +94,7 @@ int cmd_mv(int argc, const char **argv, const char *prefix)
> destination = copy_pathspec(dest_path[0], argv, argc, 1);
> } else {
> if (argc != 1)
> - usage_with_options(builtin_mv_usage, builtin_mv_options);
> + die("destination '%s' is not a directory", dest_path[0]);
> destination = dest_path;
> }
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html