On 12/12/2011 07:43 AM, Jeff King wrote: > On Sun, Dec 11, 2011 at 07:42:03PM +0100, Michael Haggerty wrote: >> 2. The configure problem causes git_vsnprintf() to be wrapped around the >> C library version. This leads to many failures in the test suite. I >> suppose that git_vsnprintf() is broken in some way. > > I enabled SNPRINTF_RETURNS_BOGUS manually and was able to see the test > suite failures. Very oddly, I could get them while running the full > suite in parallel, but when I ran individual scripts, the problem went > away. Which makes no sense to me at all. > > However, I peeked at the git_vsnprintf function, and one obvious error > is that it calls vsnprintf multiple times on the same va_list. Thanks for the quick response! Yes, I think you've hit the nail on the head. (Though I think Andreas is correct that va_end() needs to be called on the copies.) Either with or without va_end(), your patch fixes the test suite failures for me. > I'll leave the issue of "-std=c89" triggering SNPRINTF_RETURNS_BOGUS to > people who know and care about autoconf. My gut is to say "don't do > that". Git is not actually pure c89. [...] OK, I can live with that. Poor Junio will probably be stuck correcting my non-c89isms again, though :-( Michael -- Michael Haggerty mhagger@xxxxxxxxxxxx http://softwareswirl.blogspot.com/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html