Good analysis; thanks. Back when c4582f9 (Add compat/snprintf.c for systems that return bogus, 2008-03-05) was done we didn't have va_copy emulation available in git-compat-util.h but now we do, so I agree that this is an Obviously Correct thing to do. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html