Nguyễn Thái Ngọc Duy wrote:
> [Subject: Convert resolve_ref+xstrdup to new resolve_refdup function]
I like it.
> --- a/builtin/revert.c
> +++ b/builtin/revert.c
> @@ -901,7 +901,7 @@ static int rollback_single_pick(void)
> if (!file_exists(git_path("CHERRY_PICK_HEAD")) &&
> !file_exists(git_path("REVERT_HEAD")))
> return error(_("no cherry-pick or revert in progress"));
> - if (!resolve_ref("HEAD", head_sha1, 0, NULL))
> + if (read_ref_full("HEAD", head_sha1, 0, NULL))
> return error(_("cannot resolve HEAD"));
> if (is_null_sha1(head_sha1))
> return error(_("cannot abort from a branch yet to be born"));
Unrelated change that snuck in, I assume?
The rest of the patch looks very sensible and no-op-like. :)
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html