Sam Vilain <sam@xxxxxxxxxx> wrote: > Eric Wong wrote: > > Also, incremental fetches (or fetching more than 1k sequential > > revisions) would probably fail. To fix this, read the offset of last > > entry in .rev_db instead of git-svn-id: from the last commit to get the > > last revision. But since rebuild won't work as expected; losing the > > .rev_db file means you wouldn't be able to fetch from the SVK repo > > anymore (but the original upstream one will be fine). > > > > One last thing: feature should be made optional. I actually work > > day-to-day on a repository that was created with svm/SVN::Mirror, > > the original repository no longer exists; but the mirrored one > > still has these properties (I suppose I could remove the props > > server-side, but some people may not have the permissions). > > ok, I'll work on that and the other issues you highlighted... possibly > the overhead of fetching the revprops during mirroring might hurt a > little for people not doing this, too. Thanks for reviewing the patch! For the git-svn in master using the delta fetcher; there's no additional overhead to fetch properties. I want to ditch the old non-delta fetching code (it's only a mild performance benefit when using local repositories) if I could get do_switch() working correctly. -- Eric Wong - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html