Jonathan Nieder <jrnieder@xxxxxxxxx> writes: > This is also not "Additionally", as in "As a separate change that > maybe should have been another patch but I am too lazy". Rather, it > is a necessary change that is part of the same task. So I would > write: > > Breaks in a test assertion's && chain can potentially hide failures > from earlier commands in the chain. Fix these breaks. > > 'unset' returns non-zero status when the variable passed was already > unset on some shells, so now that the status is tested we need to > change these instances to 'safe_unset'. > > Erm, sane_unset, not safe_unset. Did you even test this? Thanks for careful reading and many constructive review comments. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html