Ramkumar Ramachandra wrote: > Put the opening quote starting each test on the same line as the > test_expect_* invocation. While at it: I suspect the above description, while it does describe your patch, does not describe the _reason_ that the patch exists or that someone would want to apply it. Isn't it something more like: Make the following changes pertaining to &&-chaining, for some good reason that I will describe: - ... While at it, clean up the style to fit the prevailing style. That means: - Put the opening quote starting each test on the same line as ... I didn't read over the patch again. Has it changed since v1? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html